Store sharedHistory flag for inbound Megolm sessions
#1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
a team,
ismailgulek and
ariskotsomitopoulos
and removed request for
a team
Anderas
commented
Apr 21, 2022
Anderas
commented
Apr 21, 2022
Anderas
commented
Apr 21, 2022
ismailgulek
suggested changes
Apr 21, 2022
Anderas
commented
Apr 22, 2022
...SDK/Data/RoomSummaryStore/CoreData/MXCoreDataRoomSummaryStore.xcdatamodeld/.xccurrentversion
Show resolved
Hide resolved
ismailgulek
reviewed
Apr 22, 2022
| @@ -47,8 +47,14 @@ | |||
| "MXHTTPAdditionalHeadersUnitTests", | |||
| "MXJSONModelUnitTests", | |||
| "MXKeyProviderUnitTests", | |||
| "MXLoggerUnitTests\/testDeleteLogFiles", | |||
There was a problem hiding this comment.
Can you manually edit the file to just include the class names? And can you also include them in UnitTestsWithSanitizers.xctestplan?
ismailgulek
suggested changes
Apr 22, 2022
ismailgulek
approved these changes
Apr 22, 2022
This was referenced Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to element-hq/element-ios#4947 which is an implementation of matrix-org/matrix-spec-proposals#3061
This PR stores a
sharedHistoryflag on allMXOlmInboundGroupSessions, which reflects the current history visibility of a room. In a future PR this flag will be used to determine which sessions can be shared with other users when invited.The changes in this PR:
sharedHistoryflag toMXOlmInboundGroupSessionand other related objects, so that it can be both persisted as well as backed up to the serverroomIdtoMXRealmOlmInboundGroupSessionso that inbound sessions can be fetched byroomIdin the future (i.e. "share keys per room"). Otherwise we would need to fetch them all, deserialize the data and only then filter in memory.MXMegolmEncryption.mwhich checks whether a session should be reset and add another check based on room history visibility change