Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track non-fatal issues via analytics if consent provided #1503

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Jun 16, 2022

Use existing MXAnalyticsDelegate to track any non-fatal issues, i.e. anything logged via MXLog.failure or MXLogFailure.

The SDK itself is not responsible for tracking the issues, it merely sends relevant information via delegate. If a client does not set the delegate, or the user has not consenting to sending crash and analytics data, no issues will be tracked.

@Anderas Anderas changed the title Track non-fatal issues via analytics Track non-fatal issues via analytics if consent provided Jun 16, 2022
@Anderas Anderas requested review from a team and gileluard and removed request for a team June 16, 2022 12:07
Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Anderas Anderas merged commit 6184077 into develop Jul 5, 2022
@Anderas Anderas deleted the andy/sentry branch July 5, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants