Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more crypto integration tests #1526

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Enable more crypto integration tests #1526

merged 3 commits into from
Jul 18, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Jul 14, 2022

No description provided.

@Anderas Anderas requested review from a team and pixlwave and removed request for a team July 14, 2022 15:12
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry I was a bit slow to notice this.

@Anderas
Copy link
Contributor Author

Anderas commented Jul 15, 2022

LGTM, sorry I was a bit slow to notice this.

I don't think 2hrs since raising the PR is slow 😄 . Will actually have to disable a few of the failing ones first

@Anderas Anderas changed the base branch from develop to andy/warnings July 15, 2022 18:40
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #1526 (422bf6d) into andy/warnings (07bc82f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##           andy/warnings    #1526      +/-   ##
=================================================
- Coverage          12.05%   12.05%   -0.01%     
=================================================
  Files                512      512              
  Lines              83816    83822       +6     
  Branches           35783    35785       +2     
=================================================
  Hits               10103    10103              
- Misses             73345    73351       +6     
  Partials             368      368              
Impacted Files Coverage Δ
MatrixSDKTests/MXCrossSigningTests.m 0.00% <0.00%> (ø)
MatrixSDKTests/MXCryptoKeyVerificationTests.m 0.00% <0.00%> (ø)
MatrixSDKTests/MXCryptoShareTests.m 0.00% <0.00%> (ø)
MatrixSDK/Data/MXRoom.m 0.00% <0.00%> (ø)
MatrixSDK/Utils/MXTools.m 33.37% <0.00%> (ø)
MatrixSDK/JSONModels/MXEvent.m 33.41% <0.00%> (ø)
MatrixSDK/Data/MXRoomAccountData.m 0.00% <0.00%> (ø)
MatrixSDK/JSONModels/MXJSONModels.m 6.57% <0.00%> (ø)
MatrixSDK/Utils/MXBugReportRestClient.m 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07bc82f...422bf6d. Read the comment docs.

@Anderas
Copy link
Contributor Author

Anderas commented Jul 18, 2022

@pixlwave I cheated a little and made some of the tests pass by increasing the wait time from 1 to 5 seconds. It is not ideal, but at this point I'd rather have them pass at all, before making them pass quick, otherwise I won't be able to validate some of the incoming crypto refactors.

Base automatically changed from andy/warnings to develop July 18, 2022 09:14
@Anderas Anderas merged commit b83b814 into develop Jul 18, 2022
@Anderas Anderas deleted the andy/crypto_tests branch July 18, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants