-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threads: added support to read receipts (MSC3771) #1617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some inline comments, otherwise lgtm
MatrixSDK/JSONModels/MXEvent.m
Outdated
} | ||
} | ||
|
||
[list addObject:threadId ?: [NSNull null]]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we use kMXEventTimelineMain
instead of NSNull
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still must support RR without thread ID (unthreaded RR) sent by old clients. In this case we have to set the thread ID as nil
so the RR will be stored in all thread and main timelines as per MSC.
- Update after review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A tiny comment inline, otherwise LGTM!
- Fixed CI build error
Codecov ReportBase: 16.16% // Head: 16.07% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1617 +/- ##
===========================================
- Coverage 16.16% 16.07% -0.09%
===========================================
Files 580 581 +1
Lines 91432 91980 +548
Branches 38555 38807 +252
===========================================
+ Hits 14777 14789 +12
- Misses 76176 76711 +535
- Partials 479 480 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
- Update after review
needed for element-hq/element-ios#6663