Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads: removed "unread_thread_notifications" from sync filters #1631

Conversation

gileluard
Copy link
Contributor

@gileluard gileluard requested review from a team, ismailgulek and Anderas and removed request for a team November 10, 2022 12:25
Copy link
Contributor

@Anderas Anderas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be awesome to add some unit tests for this to avoid future regressions

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…server that doesn't support MSC3773

- Update after review
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 36.22% // Head: 36.20% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (a175e71) compared to base (d70c5af).
Patch coverage: 19.85% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1631      +/-   ##
===========================================
- Coverage    36.22%   36.20%   -0.03%     
===========================================
  Files          582      583       +1     
  Lines        92316    92518     +202     
  Branches     40130    40227      +97     
===========================================
+ Hits         33444    33494      +50     
- Misses       57872    58023     +151     
- Partials      1000     1001       +1     
Impacted Files Coverage Δ
...trixSDK/Crypto/CrossSigning/MXCrossSigningV2.swift 21.25% <0.00%> (ø)
...trixSDK/Crypto/CryptoMachine/MXCryptoMachine.swift 0.00% <0.00%> (ø)
MatrixSDK/Crypto/MXCryptoV2.swift 0.81% <0.00%> (+<0.01%) ⬆️
MatrixSDK/Data/Filters/MXFilterJSONModel.m 30.90% <0.00%> (-3.10%) ⬇️
MatrixSDK/JSONModels/MXMatrixVersions.m 9.21% <0.00%> (-0.38%) ⬇️
...s/Crypto/CryptoMachine/MXCryptoProtocolStubs.swift 51.31% <0.00%> (ø)
MatrixSDKTests/MXMatrixVersionsUnitTests.swift 0.00% <0.00%> (ø)
MatrixSDKTests/MXRoomEventFilterUnitTests.swift 0.00% <0.00%> (ø)
...pto/KeyBackup/Engine/MXCryptoKeyBackupEngine.swift 47.85% <11.11%> (-1.06%) ⬇️
...o/Algorithms/RoomEvent/MXRoomEventDecryption.swift 65.83% <38.09%> (-3.00%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gileluard gileluard merged commit ad351d2 into develop Nov 14, 2022
@gileluard gileluard deleted the gil/7066-unread_thread_notifications_shouldn_t_be_sent_if_the_homeserver_doesn_t_support_notifications_per_threads branch November 14, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants