Perform crypto migration if necessary #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
a team and
flescio
and removed request for
a team
Anderas
force-pushed
the
andy/migrate_crypto
branch
from
7990397
to
5146f44
Compare
Anderas
force-pushed
the
andy/migrate_crypto
branch
from
5146f44
to
eeb3456
Compare
flescio
approved these changes
Jan 19, 2023
Rename MXSessionSyncProgress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mechanism that will migrate legacy crypto database into the new rust-based crypto sdk if neccessary. This is tracked via an existing
MXCryptoVersionenum that now has a new...Deprecatedvariant. If we then launch crypto V2 whilst legacy database is not yet deprecated, we will trigger migration, and if successful, write the deprecated version into the legacy db.Another change in this PR is separating
isAvailableandisEnabledparameters for the new crypto sdk. One serves as a feature flag around the entire SDK, controlling whether we show any labs options to the user, whereas the other controls whether we are actually using the legacy or rust-based crypto.Lastly add a few more integration tests for migration (notably cross-signing status), though the test will currently fail until rust-side PR is merged