Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constants for mention room power levels. #1750

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Mar 27, 2023

Adds kMXRoomPowerLevelNotificationsRoomKey and kMXRoomPowerLevelNotificationsRoomDefault and allows encrypted messages to be highlighted if the contain @room.

Part of element-hq/element-ios#7453

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 21.05% and no project coverage change.

Comparison is base (630d112) 17.81% compared to head (7fb733d) 17.82%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1750   +/-   ##
========================================
  Coverage    17.81%   17.82%           
========================================
  Files          615      615           
  Lines        97009    97026   +17     
  Branches     40685    40696   +11     
========================================
+ Hits         17285    17291    +6     
- Misses       79213    79223   +10     
- Partials       511      512    +1     
Impacted Files Coverage Δ
MatrixSDK/JSONModels/MXRoomPowerLevels.m 0.00% <ø> (ø)
...ter/Checker/MXPushRuleEventMatchConditionChecker.m 64.70% <21.05%> (-26.48%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pixlwave pixlwave merged commit e297c00 into develop Mar 28, 2023
@pixlwave pixlwave deleted the doug/at-mention branch March 28, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants