Upgrade verification if necessary #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/upgrade_security
branch
from
dca71bc
to
fa01420
Compare
Anderas
requested review from
a team,
flescio and
BillCarsonFr
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## hotfix/0.26.4 #1751 +/- ##
================================================
Coverage ? 37.80%
================================================
Files ? 615
Lines ? 97060
Branches ? 41929
================================================
Hits ? 36696
Misses ? 59314
Partials ? 1050 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
needsVerificationUpgradeproperty when migrating from legacy to rust crypto, which will be used to display altered UX for "verify your session" modal. This is because sessions considered as verified in the legacy crypto should not always be considered as verified in rust crypto, as the latter imposes stricter rules on session verification. In case the rust does consider the session as verified the property is reset.Note that this is not meant to be 100% reliable way to detect verification state change. For instance if legacy crypto was already unverified, migrating to rust would still display the "upgrade verification" dialoge. This is acceptable, given that the "upgrade verification" prompt will only be shown until either successful verification or ignoring of the alert.
Additionally keep the existing realm store around after migration instead of deleting it. It will be removed in a future PR.