Delete data for mismatched accounts #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/delete_data
branch
from
f5c841f to
a1314b7
Compare
Anderas
requested review from
a team and
aringenbach
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## hotfix/0.26.6 #1763 +/- ##
================================================
Coverage ? 25.84%
================================================
Files ? 616
Lines ? 97191
Branches ? 41887
================================================
Hits ? 25118
Misses ? 71254
Partials ? 819 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
aringenbach
approved these changes
Apr 12, 2023
| @@ -36,6 +36,8 @@ class MXCryptoMachine { | |||
| } | |||
|
|
|||
| private static let kdfRounds: Int32 = 500_000 | |||
| // Error type will be moved to rust sdk | |||
There was a problem hiding this comment.
Maybe add this as a FIXME/TODO for visibility ?
There was a problem hiding this comment.
I am not a fan of adding TODOs to code, but it is tracked in a draft issue on a sprint board so to be resolved asap. Here its meant to be an explanatory comment rather than a TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves element-hq/element-ios#7488
When we recieve a "Mismatched account" error (meaning we have existing data for the current user but under a different device) we need to delete the previous data first before we can try to create the machine.
Note that this behaviour should not be happening as we delete data on logouts, but there are clearly edge-cases where this still occurs. In those cases we will log the error.