Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch device info by sender key #1765

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Fetch device info by sender key #1765

merged 2 commits into from
Apr 12, 2023

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Apr 12, 2023

When fetching device info, ensure that we retrieve it via its sender key, which may not be set on an event yet, but is a part of the decryption result.

Additionally upgrade crypto sdk version

@Anderas Anderas changed the title Upgrade MatrixSDKCrypto Upgrade Crypto SDK Apr 12, 2023
@Anderas Anderas requested review from a team and flescio and removed request for a team April 12, 2023 11:08
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +12.12 🎉

Comparison is base (a1314b7) 25.84% compared to head (95ad041) 37.96%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           hotfix/0.26.6    #1765       +/-   ##
==================================================
+ Coverage          25.84%   37.96%   +12.12%     
==================================================
  Files                616      616               
  Lines              97191    97253       +62     
  Branches           41887    41995      +108     
==================================================
+ Hits               25118    36923    +11805     
+ Misses             71254    59282    -11972     
- Partials             819     1048      +229     
Impacted Files Coverage Δ
...xSDK/Crypto/Algorithms/Megolm/MXMegolmDecryption.m 87.46% <100.00%> (+1.67%) ⬆️
...lgorithms/Megolm/MXMegolmDecryptionUnitTests.swift 95.96% <100.00%> (+95.96%) ⬆️

... and 224 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Anderas Anderas changed the title Upgrade Crypto SDK Fetch device info by sender key Apr 12, 2023
@Anderas Anderas requested review from pixlwave and removed request for flescio April 12, 2023 13:05
Copy link
Contributor

@flescio flescio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Anderas Anderas removed the request for review from pixlwave April 12, 2023 13:07
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Anderas Anderas merged commit 15c9326 into hotfix/0.26.6 Apr 12, 2023
@Anderas Anderas deleted the andy/crypto_version branch April 12, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants