Groups: Display flair for users in room history. #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MXRestClient: Add the method to get the publicised groups for a list of users. MXSession: Cache the publicised groups of the matrix users in order to limit the server requests. element-hq/riot-meta#118
manuroe
approved these changes
Feb 5, 2018
MatrixSDK/MXSession.m
Outdated
| } | ||
|
|
||
|
|
||
| } failure:nil]; |
There was a problem hiding this comment.
In case of failure, it may worth to put userId in userIdsWithOutdatedPublicisedGroups, no?
| If this information is not available or marked as outdated, this method returns the current | ||
| value and triggers a server request to retrieve the actual publicised groups of this user. | ||
| Listen to `kMXSessionDidUpdatePublicisedGroupsForUsersNotification` to be notified in case of update. | ||
|
|
There was a problem hiding this comment.
Could you also indicate that there will be no http requests if there is already one in progress for this userId?
Fix Manu's remarks element-hq/riot-meta#118
manuroe
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MXRestClient: Add the method to get the publicised groups for a list of users.
MXSession: Cache the publicised groups of the matrix users in order to limit the server requests.
element-hq/riot-meta#118