-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2e keys backup #591
Merged
Merged
E2e keys backup #591
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
262a094
Add MXEncryptedContentInfo class
giomfo 8e2f54f
Add MXEncryptedContentFile and MXEncryptedContentKey classes
giomfo 6c3c23d
remove wrong files
giomfo 51c8f84
Update MatrixSDK header
giomfo 408d843
Add antivirus server support - MXRestClient:
giomfo 0e83053
Merge branch 'develop' into add_antivirus_server
giomfo 27bbc97
Merge branch 'develop' into add_antivirus_server
giomfo de4f03f
Tests: Make MXRealmCryptoStore work the first time tests are launched…
manuroe c78c3a7
Keys backup: Added data models
manuroe f0aaed4
Keys backup: MXKeyBackupVersion.version is now a string in the spec
manuroe 89c9a0c
Keys backup: MXKeyBackupVersion: Guarantee parameters non-nullabililty
manuroe 103588e
Keys backup: Add models and APIs to backup and retrieve keys
manuroe 1d013c5
Keys backup: Add delete APIs
manuroe d189314
Keys backup: Move everything to a dedicated /Crypto/Backup folder
manuroe 68d5f7a
Keys backup: Add MXCryptoStore APIs.
manuroe 881d519
MXTools: Add addWhiteSpacesToString method
manuroe c3efcb2
Keys backup: Add MXRecoryKey to manage Base58 representation of the p…
manuroe d3bec5a
Keys backup: MXKeyBackupVersion: We need to be to create such object
manuroe 7ca520f
Keys backup: Add MXKeyBackup to manage keys backup
manuroe e170961
Keys backup: Refine MXKeyBackupState
manuroe 2b719c0
Keys backup: MXKeyBackup: Use version as string in interfaces
manuroe 62755a5
Keys backup: MXKeyBackup: Add backupAllGroupSessions and backupProgre…
manuroe ba0b66d
Keys backup: Start to plug in all together and tests
manuroe b5a73e9
Keys backup: MXKeyBackup: Manage error in enableKeyBackup
manuroe 9017271
Keys backup: MXKeyBackup: Manage error in backupAllGroupSessions
manuroe 4982f4a
Keys backup: Fix [MXRestClient sendKeysBackup:]
manuroe 58718d3
Keys backup: Mark keys as backed up when they are
manuroe 8fd1859
Keys backup: [MXKeyBackup backupAllGroupSessions]: make sure progress…
manuroe 1b60df3
Keys backup: Fix and finish MXMegolmBackupAuthData implementation
manuroe ea1d1ef
Keys backup: Add tests
manuroe fedadea
Keys backup: MXRestClient: Improve naming of the new methods
manuroe 5ecdefe
MXCrypto: importRoomKeys methods now return number of imported keys.
manuroe 25acbea
Keys backup: Make the full flow of encrypting/decrypting megolm keys …
manuroe e920cbd
Keys backup: Add testRestoreKeyBackup
manuroe fb46439
Keys backup: Do not backup keys we got from a backup recovery
manuroe 40016ad
Keys backup: Fix testRestoreKeyBackup
manuroe 84a54c5
MXSession: configure antivirus scanner use. (#592)
giomfo 9f693e6
Keys backup: Use another lib to manage base58
manuroe 0e65948
Keys backup: testRESTDeleteBackupKeys appreciates the server fix
manuroe 8fb66e6
Keys backup: Add [MXKeyBackup isKeyBackupTrusted:]
manuroe 331eac1
Keys backup: Add [MXKeyBackup checkAndStartKeyBackup:] to start backup
manuroe 3e1b963
Keys backup: Detect M_WRONG_ROOM_KEYS_VERSION and create the correspo…
manuroe 481623f
MXCryptoStore: add deviceWithIdentityKey method
manuroe 4214f61
Keys backup: Code cleaning
manuroe c3e871b
Keys backup: Store backup version so that at startup we can reset bac…
manuroe 9786808
Keys backup: Improve [MXKeyBackup version:] comments and usage
manuroe 4eb56f9
Keys backup: Make sure [MXKeyBackup backupAllGroupSessions:] correctl…
manuroe 1078df9
Keys backup: Start backup once a device has been verified
manuroe ba4480d
Keys backup: Fix typo sessionIdSenderKer -> sessionIdSenderKey
manuroe 86d5548
Keys backup: createKeyBackupVersion: reset backup markers only on suc…
manuroe 516919e
Keys backup: Thanks into account Benoit's comments
manuroe fe52770
Keys backup: Thanks into account Benoit's comments
manuroe 40ba3a2
Keys backup: Thanks into account Benoit's comments
manuroe 18f7ee8
Keys backup: MXRealmCryptoStore: Do not increment 2 db schema version…
manuroe 0d1b8d3
Merge branch 'develop' into e2e_keys_backup
manuroe 6738031
Keys backup: Update CHANGES
manuroe 6e90dc2
Keys backup: MXKeyBackUp: Make sure we retry on failure on sendKeyBackup
manuroe cafe8ab
Merge branch 'develop' into add_antivirus_server
giomfo 9d9edbd
Keys backup: Podfile.lock with Base58
manuroe cbd4bf8
Merge remote-tracking branch 'origin/pr/585' into e2e_keys_backup
manuroe 397757f
Keys backup: Manage Benoit's comments
manuroe c6ddcd5
Keys backup: Manage Steve's comments
manuroe 4ad1641
Keys backup: Fix typo
manuroe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a risk of infinite retry in case of no network issue, or other permanent error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but no because the
MXHTTPClient
will wait that the network is back.In case of other kind of error (like timeout on bad network connectivity), yes, we can loop but with a delay between 0 and 10s and it seems to be the best to do in this case.