MXMediaManager/MXMediaLoader: Do not allow non-mxc content URLs. #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The Matrix Media Content repository contants are moved to MXEnumConstants.h - MXSession: Add a MediaManager instance to handle directly the media stored on the Matrix Content repository. - MediaManager: an instance is initialized with homeserver URL to be able to handle itself the Matrix Content URI (mxc://...). - API break: "- (NSString *)urlOfIdenticon:(NSString *)identiconString" is moved from MXRestClient to MXMediaManager.
…URI (in the form of "mxc://...").
- Replace all the set of notifications with only one notification based on state change
…ned url is nil whatever the value returned by the server
which should not be used anymore.
This was referenced Nov 11, 2018
Merged
manuroe
reviewed
Nov 12, 2018
| @"info": [@{ | ||
| @"thumbnail_url": fakeMediaManagerThumbnailURL, | ||
| @"thumbnail_url": fakeMediaURI, | ||
| @"thumbnail_info": @{ | ||
| @"mimetype": @"image/jpeg", |
There was a problem hiding this comment.
Not for this PR but that would be nice MIME type constants
| /** | ||
| Statistics on the operation in progress. | ||
| - kMXMediaLoaderProgressValueKey: progress value in [0, 1] range (NSNumber object) [In case of upload, the properties |
There was a problem hiding this comment.
Note for future: kMXMediaLoaderProgressValueKey, kMXMediaLoaderProgressValueKey and kMXMediaLoaderTotalBytesCountKey values could all fit a NSProgress object.
kMXMediaLoaderCurrentDataRateKey could even be stored as userInfo of this NSProgress object.
And increase MediaCacheSdkVersion
manuroe
approved these changes
Nov 13, 2018
giomfo
added a commit
to tchapgouv/tchap-ios
that referenced
this pull request
Nov 14, 2018
Improvements: * Replace the deprecated MXMediaManager and MXMediaLoader interfaces use (see matrix-org/matrix-ios-sdk/pull/593). * Replace the deprecated MXKAttachment and MXKImageView interfaces use (see matrix-org/matrix-ios-kit/pull/487). * Server Quota Notices: Implement the blue banner (1937). * Lazy loading: Enable it by default (if the homeserver supports it). * i18n: Add Spanish (sp). * Settings: Make advanced info copyable (2023). * Settings: Made cryptography info copyable, thanks to @daverPL (PR 1999). Bug fix: * Notifications: old notifications can reappear (1985). * Fix missing read receipts when lazy-loading room members. * Weird text color when selecting a message (2046). * Fix input toolbar reset in RoomViewController on MXSession state change (2006 and 2008). * User defaults: the preset application language (if any) is ignored. * Recents: Avoid to open a room twice (it crashed on room creation on quick HSes). * Riot-bot: Do not try to create a room with it if the user homeserver is not federated. * Empty app if initial /sync fails (1975). * Fix possible race conditions in direct rooms management.
giomfo
added a commit
to tchapgouv/tchap-ios
that referenced
this pull request
Nov 14, 2018
* Rebase onto vector-im/riot-ios: Improvements: * Replace the deprecated MXMediaManager and MXMediaLoader interfaces use (see matrix-org/matrix-ios-sdk/pull/593). * Replace the deprecated MXKAttachment and MXKImageView interfaces use (see matrix-org/matrix-ios-kit/pull/487). * Server Quota Notices: Implement the blue banner (1937). * Lazy loading: Enable it by default (if the homeserver supports it). * i18n: Add Spanish (sp). * Settings: Make advanced info copyable (2023). * Settings: Made cryptography info copyable, thanks to @daverPL (PR 1999). Bug fix: * Notifications: old notifications can reappear (1985). * Fix missing read receipts when lazy-loading room members. * Weird text color when selecting a message (2046). * Fix input toolbar reset in RoomViewController on MXSession state change (2006 and 2008). * User defaults: the preset application language (if any) is ignored. * Recents: Avoid to open a room twice (it crashed on room creation on quick HSes). * Riot-bot: Do not try to create a room with it if the user homeserver is not federated. * Empty app if initial /sync fails (1975). * Fix possible race conditions in direct rooms management. - Remove deprecated MXKImageView interface use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
Bug Fix:
Deprecated API:
API break: