Edits start - reaction end #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gatedReactionsUpdater
…regation store. Every event received in timelines (live or not) is now processed by MXAggregation. This fixes issues like "Unreact can have no visual effect" (element-hq/element-ios#2470)
6 tasks
|
|
||
| @interface MXAggregatedEditsUpdater () | ||
|
|
||
| @property (nonatomic, weak) NSString *myUserId; |
There was a problem hiding this comment.
Remove weak attribute, seems to be a copy/paste issue.
|
|
||
| @interface MXAggregatedReactionsUpdater () | ||
|
|
||
| @property (nonatomic, weak) NSString *myUserId; |
There was a problem hiding this comment.
Remove weak attribute, seems to be a copy/paste issue.
SBiOSoftWhare
approved these changes
May 24, 2019
…on_end # Conflicts: # MatrixSDK/Aggregations/MXAggregations.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started this branch to implement edits. I first made a refactor to let room for the edits part in MXAggregation but I got stucked in edits spec so I came back to reactions and fix some (maybe all) things.
This PR contains
MXAggregatedReactionsUpdaterto handle storage and updates (and hack) for reactionMXAggregatedEditsUpdatersend_relationCommits can be reviewed one by one.
Test
They pass but with some restrictions:
experimental_msc1849_support_enabled: trueMXAggregatedReactionTestsrelated to server or spec issues.