This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Implement part #20
Open
Implement part #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be updated to do a similar thing as the join here, in terms of sending a |
|
Any ETA on when this could get merged? |
|
@tadzik Are you still interested in getting this functionality into matrix-ircd? |
|
@jplatte I'm planning to sit back to down to this in near future once $work slows down a little, but I don't have any ETA. If you wanna follow up on this issue/patch, go right ahead :) |
|
I don't have the time myself right now, just doing triage :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on #19 being merged. It works perfectly fine as far as the matrix side of things is concerned, though when I tried it on weechat it didn't automatically close the chat buffer; not sure if that's weechat's fault or does some feedback irc message needs to be sent back to the user? Also,
RoomLeaveInputandRoomLeaveResponseexist only to satisfy thedo_json_post's API; perhaps it'd be better to either teachdo_json_postto deal with empty payloads, or create a dummy struct for those? What do you think?