Add support for olm fallback keys #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
changed the title
jryans
approved these changes
Sep 16, 2020
src/sync.js
Outdated
| @@ -1361,6 +1361,15 @@ SyncApi.prototype._processSyncResponse = async function( | |||
| const currentCount = data.device_one_time_keys_count.signed_curve25519 || 0; | |||
| this.opts.crypto.updateOneTimeKeyCount(currentCount); | |||
| } | |||
| if (this.opts.crypto && data.device_unused_fallback_keys) { | |||
There was a problem hiding this comment.
Hmm, so a supporting server will list your fallback key in every sync response indefinitely? It would nice if there were some way for it to only appear when changed, rather than every time, but I'll leave that to the spec and server discussion.
There was a problem hiding this comment.
Added a comment to the MSC for this.
|
@jryans already approved this, but it has probably changed enough since then that it should be reapproved |
jryans
approved these changes
Oct 7, 2020
This was referenced Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/synapse#8312 and https://gitlab.matrix.org/matrix-org/olm/-/merge_requests/13 (Should not be merged until a new olm release is made and the olm dependency is bumped.)
Implements MSC2732