Unstable implementation of MSC3089: File Trees #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSC: matrix-org/matrix-spec-proposals#3089 Includes part of MSC3088 (room subtyping): matrix-org/matrix-spec-proposals#3088 The NamespacedValue stuff is borrowed from the Extensible Events implementation PR in the react-sdk as a useful thing to put here. When/if the MSCs become stable, we'd convert the values to enums and drop the constants (or keep them for migration purposes, but switch to stable). This flags the whole thing as unstable because it's highly subject to change.
t3chguy
reviewed
Jun 10, 2021
t3chguy
reviewed
Jun 10, 2021
t3chguy
reviewed
Jun 10, 2021
t3chguy
reviewed
Jun 10, 2021
t3chguy
reviewed
Jun 10, 2021
t3chguy
reviewed
Jun 11, 2021
|
@t3chguy ptal. I've punted a proper conversion of the utils test out to element-hq/element-web#17630 in the interest of speed. |
t3chguy
reviewed
Jun 14, 2021
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
reviewed
Jun 14, 2021
spec/unit/utils.spec.ts
Outdated
| expect(baseToString(BigInt(53), "abcdefghijklmnopqrstuvwxyz")).toEqual('cb'); | ||
| // Verify the whole alphabet | ||
| for (let i = BigInt(1); i <= DEFAULT_ALPHABET.length; i++) { | ||
| console.log({i}); // for debugging |
There was a problem hiding this comment.
this can probably go away now, or be added to the message on the expect itself
There was a problem hiding this comment.
keeping it around for the debugging side, like the other test which does this. Can't have expect messages without a library, so out of scope for this PR.
t3chguy
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a heavily opinionated set of classes to help downstream projects implement file trees. There is no UI component to this (for now). As an unstable implementation, this has known gaps that will be filled (eventually, probably).
This has a very specific usecase (managed file trees) and is not entirely ready for usecases like Element or bridges yet - its opinions are formed out of this usecase.
Such opinionated code is a bit of a first in the js-sdk stack, but for this sort of downstream project it helps with development. The downstream project using this is even more opinionated, and it is expected that the before dropping the unstable flag that this implementation would be refactored to match whatever structure the js-sdk has at that time. Please ping me on Matrix for more information/reference material (if appropriate).
There is no expectation or guarantee that this API surface be maintained as such. Breaking changes are encouraged and expected.
The NamespacedValue stuff is borrowed from the Extensible Events implementation PR in the react-sdk as a useful thing to put here. When/if the MSCs become stable, we'd convert the values to enums and drop the constants (or keep them for migration purposes, but switch to stable).
MSC: matrix-org/matrix-spec-proposals#3089
Includes part of MSC3088 (room subtyping): matrix-org/matrix-spec-proposals#3088
Note for diligent community members: This does not count as an MSC implementation due to the lack of UI component.