Strip direction override characters from display names #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strip RLO and LRO characters from name and rawDisplayName so they can safely be embedded into other text without messing up the text ordering. Fixes element-hq/element-web#1712
t3chguy
approved these changes
Oct 20, 2021
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Oct 20, 2021
Strip RLO & LRO chars from display names when rendering text for member events. See matrix-org/matrix-js-sdk#1992 - also necessary here because we use the display name in the event content rather than from the member object sanitised by the js-sdk.
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Oct 20, 2021
#6999) Strip RLO & LRO chars from display names when rendering text for member events. See matrix-org/matrix-js-sdk#1992 - also necessary here because we use the display name in the event content rather than from the member object sanitised by the js-sdk.
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Nov 8, 2021
* Mark old verification methods as deprecated ([\matrix-org#1994](matrix-org#1994)). * Try to set a sender on search result events if possible ([\matrix-org#2004](matrix-org#2004)). * Port some changes from group calls branch to develop ([\matrix-org#2001](matrix-org#2001)). Contributed by @SimonBrandner. * Fetch room membership from server rather than relying on stored data ([\matrix-org#1998](matrix-org#1998)). * Add method to fetch the MSC3266 Room Summary of a Room ([\matrix-org#1988](matrix-org#1988)). * Don't show `Unable to access microphone` when cancelling screensharing dialog ([\matrix-org#2005](matrix-org#2005)). Fixes element-hq/element-web#19533 and element-hq/element-web#19533. Contributed by @SimonBrandner. * Strip direction override characters from display names ([\matrix-org#1992](matrix-org#1992)). Fixes element-hq/element-web#1712 and element-hq/element-web#1712.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip RLO and LRO characters from name and rawDisplayName so they
can safely be embedded into other text without messing up the text
ordering.
Fixes element-hq/element-web#1712
Here's what your changelog entry will look like:
🐛 Bug Fixes