-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beacon event types from MSC3489 #2230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Codecov Report
@@ Coverage Diff @@
## develop #2230 +/- ##
===========================================
+ Coverage 57.82% 57.84% +0.02%
===========================================
Files 90 91 +1
Lines 16300 16308 +8
Branches 3756 3757 +1
===========================================
+ Hits 9425 9433 +8
Misses 6875 6875
|
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
kerryarchibald
force-pushed
the
psf-772/beacon-events
branch
from
March 10, 2022 17:21
536ed45
to
e1b6ceb
Compare
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
germain-gg
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Returning to draft while matrix-org/matrix-spec-proposals#3672 is so active |
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Apr 1, 2022
* emit aggregate room beacon liveness ([\matrix-org#2241](matrix-org#2241)). * Live location sharing - create m.beacon_info events ([\matrix-org#2238](matrix-org#2238)). * Beacon event types from MSC3489 ([\matrix-org#2230](matrix-org#2230)). * Fix incorrect usage of unstable variant of `is_falling_back` ([\matrix-org#2227](matrix-org#2227)).
wx870601
added a commit
to eachchat/matrix-js-sdk
that referenced
this pull request
Apr 6, 2022
* emit aggregate room beacon liveness ([\matrix-org#2241](matrix-org#2241)). * Live location sharing - create m.beacon_info events ([\matrix-org#2238](matrix-org#2238)). * Beacon event types from MSC3489 ([\matrix-org#2230](matrix-org#2230)). * Fix incorrect usage of unstable variant of `is_falling_back` ([\matrix-org#2227](matrix-org#2227)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: matrix-org/matrix-spec-proposals#3489
Adds types and content helper functions for
m.beacon_info
andm.beacon
events.Here's what your changelog entry will look like:
✨ Features