Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PTT call mode & mute by default in PTT calls #2311

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Apr 20, 2022

No other parts of PTT calls implemented yet

For element-hq/element-call#294


Here's what your changelog entry will look like:

✨ Features

  • Add PTT call mode & mute by default in PTT calls (#2311).

No other parts of PTT calls implemented yet
@dbkr dbkr requested a review from robertlong April 20, 2022 16:05
@dbkr dbkr requested a review from a team as a code owner April 20, 2022 16:05
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@dbkr dbkr merged commit edd5069 into dbkr/ptt Apr 21, 2022
@dbkr dbkr deleted the dbkr/ptt_mute_by_default branch April 21, 2022 09:54
dbkr added a commit that referenced this pull request May 3, 2022
* Add PTT call mode & mute by default in PTT calls (#2311)

No other parts of PTT calls implemented yet

* Make the tests pass again (#2316)

3280394
made call use a bunch of methods that weren't mocked in the tests.

* Add maximum trasmit time for PTT (#2312)

on sender side by muting mic after the max transmit time has elapsed.

* Don't allow user to unmute if another user is speaking  (#2313)

* Add maximum trasmit time for PTT

on sender side by muting mic after the max transmit time has elapsed.

* Don't allow user to unmute if another user is speaking

Based on #2312
For element-hq/element-call#298

* Fix createGroupCall arguments (#2325)

Comma instead of a colon...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants