registration: add function to re-request email token #2357
Conversation
justjanne
force-pushed
the
justjanne/feat/21984-registration-email-verification
branch
from
55445ed
to
221776f
Compare
justjanne
force-pushed
the
justjanne/feat/21984-registration-email-verification
branch
from
221776f
to
58a0a7e
Compare
| /** | ||
| * Requests a new email token and sets the email sid for the validation session | ||
| */ | ||
| public requestEmailToken = async () => { |
There was a problem hiding this comment.
out of interest is there any reason this is an arrow func?
There was a problem hiding this comment.
We need to use this in the function, and while I personally would prefer to use a regular function and binding it in the constructor, across the codebase I’ve found arrow functions to be used more commonly to accomplish the same.
There was a problem hiding this comment.
Sure but the function is always called with the correct this context already (L493) so would work in either way. Its not being copied to lose its bound context anywhere yet
There was a problem hiding this comment.
But it is? It’s a public function, so it can be called with any this context. And it is called like with a different context as onClick handler in matrix-org/matrix-react-sdk#8554.
There was a problem hiding this comment.
The SDK as a whole makes the assumption that the caller will always call with the correct this context, we tend to use arrow funcs for when we want to use it as a local handler. Arrow functions here are not wrong by any means, was just curious.
There was a problem hiding this comment.
Oh, that’s an interesting assumption! Good to know, I’ve never seen a codebase that assumed this before.
There was a problem hiding this comment.
It is very much a bad assumption to have, but one we make anyway. If you feel strongly about it we could make a rule that all public methods have to be arrow functions to remedy this
|
Sadly I couldn’t migrate the tests to typescript cause the other tests do some type trickery :( |
justjanne
deleted the
justjanne/feat/21984-registration-email-verification
branch
* Implement changes to MSC2285 (private read receipts) ([\matrix-org#2221](matrix-org#2221)). * Add support for HTML renderings of room topics ([\matrix-org#2272](matrix-org#2272)). * Add stopClient parameter to MatrixClient::logout ([\matrix-org#2367](matrix-org#2367)). * registration: add function to re-request email token ([\matrix-org#2357](matrix-org#2357)). * Remove hacky custom status feature ([\matrix-org#2350](matrix-org#2350)). * Remove default push rule override for MSC1930 ([\matrix-org#2376](matrix-org#2376)). Fixes element-hq/element-web#15439. * Tweak thread creation & event adding to fix bugs around relations ([\matrix-org#2369](matrix-org#2369)). Fixes element-hq/element-web#22162 and element-hq/element-web#22180. * Prune both clear & wire content on redaction ([\matrix-org#2346](matrix-org#2346)). Fixes element-hq/element-web#21929. * MSC3786: Add a default push rule to ignore `m.room.server_acl` events ([\matrix-org#2333](matrix-org#2333)). Fixes element-hq/element-web#20788.
Type: Enhancement
Related: element-hq/element-web#21984
Related: matrix-org/matrix-react-sdk#8554
Here's what your changelog entry will look like:
✨ Features