Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webrtc: add advanced audio settings #2434

Merged
merged 2 commits into from
Nov 8, 2022
Merged

webrtc: add advanced audio settings #2434

merged 2 commits into from
Nov 8, 2022

Commits on Nov 8, 2022

  1. webrtc: add advanced audio settings 

    autoGainControl, echoCancellation, and noiseSuppression are audio
processing options that are usually enabled by default on WebRTC input
tracks.

This commit adds the possibility to enable/disable them, as they can be
undesirable in some cases (audiophile use cases). For example, one might
want to stream electronic dance music, which is basically noise, so it
should not be suppressed in that specific case.

Note that these are not exact settings, they are set as "ideal" in order
not to break anything on devices where those constraints are not
implemented.

Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    @MrAnno
    MrAnno committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    078395a View commit details
    Browse the repository at this point in the history

  2. webrtc: remove "LOG" prefix from informational messages 

    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    @MrAnno
    MrAnno committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    6476e04 View commit details
    Browse the repository at this point in the history