Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't consider room invites that are ignored to be "visible" #2496

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jesopo
Copy link

@jesopo jesopo commented Jul 6, 2022

to be rebased on #2483


Here's what your changelog entry will look like:

✨ Features

  • don't consider room invites that are ignored to be "visible" (#2496).

src/client.ts Outdated Show resolved Hide resolved
@jesopo jesopo force-pushed the ignored-invite-notification branch from f1d28e7 to a146e6c Compare July 6, 2022 13:30
@jesopo jesopo requested a review from Yoric July 6, 2022 13:48
Gnuxie added a commit to Gnuxie/matrix-react-sdk that referenced this pull request Jul 6, 2022
The command is much the same but the actual implementation
matrix-org/matrix-js-sdk#2496 will now only
hide invitations.

We now have a command to unignore invitations from a room.
@jesopo jesopo force-pushed the ignored-invite-notification branch from a146e6c to 9401b20 Compare July 7, 2022 13:19
Copy link
Contributor

@Yoric Yoric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There's an ongoing debate about getIgnoredInvites() and whether it might become more costly, but for the time being, this should be efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants