Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test typescriptification - timeline-window, scheduler, etc #2539

Merged
merged 9 commits into from
Jul 27, 2022
Merged

test typescriptification - timeline-window, scheduler, etc #2539

merged 9 commits into from
Jul 27, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Jul 26, 2022 •
edited by github-actions bot
Loading

#2353
Recommend viewing by commit

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Tasks for the team like planning label Jul 26, 2022
@kerryarchibald kerryarchibald requested a review from a team as a code owner July 26, 2022 15:11
robintown
robintown approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good otherwise

spec/unit/timeline-window.spec.ts Outdated Show resolved Hide resolved
spec/unit/timeline-window.spec.ts Outdated Show resolved Hide resolved
spec/unit/timeline-window.spec.ts Show resolved Hide resolved
spec/unit/timeline-window.spec.ts Outdated Show resolved Hide resolved
@kerryarchibald
Copy link
Contributor Author

Sorry @robintown, didn't mean to clear your review. Thanks for reviewing!

@kerryarchibald kerryarchibald enabled auto-merge (squash) July 27, 2022 15:06
@kerryarchibald kerryarchibald merged commit 4c80762 into develop Jul 27, 2022
@kerryarchibald kerryarchibald deleted the kerry/ts-unit-26-7 branch July 27, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

@SimonBrandner SimonBrandner Awaiting requested review from SimonBrandner SimonBrandner is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @robintown