Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read receipts for threads #2635

Merged
merged 12 commits into from
Sep 21, 2022
Merged

Read receipts for threads #2635

merged 12 commits into from
Sep 21, 2022

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Sep 2, 2022

For element-hq/element-web#23191
View full MSC details matrix-org/matrix-spec-proposals#3771

This PR enables read receipts for threads.

If the server advertises support for org.matrix.msc3771, the JS SDK will comply and allow sending and receiving read receipts for threads.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

  • Read receipts for threads (#2635).

Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a few nitpicks. Feel free to ignore the comments on code you just moved!

src/models/read-receipt.ts Outdated Show resolved Hide resolved
src/models/read-receipt.ts Outdated Show resolved Hide resolved
src/models/room.ts Outdated Show resolved Hide resolved
src/models/room.ts Outdated Show resolved Hide resolved
src/models/room.ts Outdated Show resolved Hide resolved
src/models/room.ts Show resolved Hide resolved
src/models/room.ts Show resolved Hide resolved
@germain-gg germain-gg enabled auto-merge (squash) September 21, 2022 07:47
@germain-gg germain-gg merged commit 2967ee6 into develop Sep 21, 2022
@germain-gg germain-gg deleted the gsouquet/read-receipts-23191 branch September 21, 2022 07:50
SimonBrandner added a commit that referenced this pull request Sep 22, 2022
* Update sonarcloud.yml (#2671)

* Update sonarcloud.yml

* test typescriptification - spec/unit/crypto/verification (#2673)

* renamed:    spec/unit/crypto/verification/request.spec.js -> spec/unit/crypto/verification/request.spec.ts

* renamed:    spec/unit/crypto/verification/qr_code.spec.js -> spec/unit/crypto/verification/qr_code.spec.ts

* renamed:    spec/unit/crypto/verification/InRoomChannel.spec.js -> spec/unit/crypto/verification/InRoomChannel.spec.ts

* fix ts issues in InRoomChannel.spec

* renamed:    spec/unit/crypto/verification/util.js -> spec/unit/crypto/verification/util.ts

* fix ts issues in util.t

* fix strict errors in util.ts

* js lint

* test typescriptification - last few unit test files (#2675)

* renamed:    spec/unit/crypto/verification/sas.spec.js -> spec/unit/crypto/verification/sas.spec.ts

* ts issues in sas.spec

* renamed:    spec/unit/crypto/verification/secret_request.spec.js -> spec/unit/crypto/verification/secret_request.spec.ts

* ts issues in secret_request.spec

* renamed:    spec/unit/crypto/verification/verification_request.spec.js -> spec/unit/crypto/verification/verification_request.spec.ts

* ts fix verification_req.spec

* renamed:    spec/browserify/sync-browserify.spec.js -> spec/browserify/sync-browserify.spec.ts

* fix strict

* formatting

* Update babel monorepo to v7.19.1 (#2681)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update typescript-eslint monorepo to v5.38.0 (#2685)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Read receipts for threads (#2635)

* Update all (#2684)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update jest monorepo to v29.0.3 (#2682)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix backpagination at end logic being spec non-conforming (#2680)

* Support to remotely toggle push notifications (#2686)

* Add unstable device_id field for MSC3881 (#2688)

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: Kerry <kerrya@element.io>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Germain <germains@element.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants