Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for call answering / candidate sending #2666

Merged
merged 8 commits into from
Sep 14, 2022
Merged

Add tests for call answering / candidate sending #2666

merged 8 commits into from
Sep 14, 2022

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Sep 13, 2022 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@dbkr dbkr added the T-Task Tasks for the team like planning label Sep 13, 2022
@dbkr dbkr requested a review from a team as a code owner September 13, 2022 15:35
SimonBrandner
SimonBrandner reviewed Sep 13, 2022
View reviewed changes
spec/unit/webrtc/call.spec.ts Outdated Show resolved Hide resolved
spec/unit/webrtc/call.spec.ts Outdated Show resolved Hide resolved
spec/test-utils/webrtc.ts Outdated Show resolved Hide resolved
@dbkr dbkr merged commit 586a313 into robertlong/group-call Sep 14, 2022
@dbkr dbkr deleted the dbkr/call_answer_tests branch September 14, 2022 08:42
@fkwp fkwp mentioned this pull request Oct 13, 2022
Closed
16 tasks
@fkwp fkwp mentioned this pull request Nov 30, 2022
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBrandner SimonBrandner SimonBrandner approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @SimonBrandner