-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch server versions API call exception when starting the client #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
X-Release-Blocker
backport staging
Label to automatically backport PR to staging branch
labels
Oct 31, 2022
florianduros
approved these changes
Oct 31, 2022
t3chguy
reviewed
Oct 31, 2022
t3chguy
approved these changes
Oct 31, 2022
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-staging staging
# Navigate to the new working tree
cd .worktrees/backport-staging
# Create a new branch
git switch --create backport-2828-to-staging
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1f3ae4bde2955f31361f733b20375221383963b0
# Push it to GitHub
git push --set-upstream origin backport-2828-to-staging
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-staging Then, create a pull request where the |
t3chguy
pushed a commit
that referenced
this pull request
Nov 1, 2022
) (cherry picked from commit 1f3ae4b)
su-ex
added a commit
to SchildiChat/element-desktop
that referenced
this pull request
Nov 4, 2022
* Fix default behavior of Room.getBlacklistUnverifiedDevices ([\#2830](matrix-org/matrix-js-sdk#2830)). Contributed by @duxovni. * Catch server versions API call exception when starting the client ([\#2828](matrix-org/matrix-js-sdk#2828)). Fixes element-hq/element-web#23634. * Fix authedRequest including `Authorization: Bearer undefined` for password resets ([\#2822](matrix-org/matrix-js-sdk#2822)). Fixes element-hq/element-web#23655.
su-ex
added a commit
to SchildiChat/element-web
that referenced
this pull request
Nov 4, 2022
* Fix default behavior of Room.getBlacklistUnverifiedDevices ([\element-hq#2830](matrix-org/matrix-js-sdk#2830)). Contributed by @duxovni. * Catch server versions API call exception when starting the client ([\element-hq#2828](matrix-org/matrix-js-sdk#2828)). Fixes element-hq#23634. * Fix authedRequest including `Authorization: Bearer undefined` for password resets ([\element-hq#2822](matrix-org/matrix-js-sdk#2822)). Fixes element-hq#23655.
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Nov 4, 2022
* Fix default behavior of Room.getBlacklistUnverifiedDevices ([\matrix-org#2830](matrix-org#2830)). Contributed by @duxovni. * Catch server versions API call exception when starting the client ([\matrix-org#2828](matrix-org#2828)). Fixes element-hq/element-web#23634. * Fix authedRequest including `Authorization: Bearer undefined` for password resets ([\matrix-org#2822](matrix-org#2822)). Fixes element-hq/element-web#23655.
su-ex
added a commit
to SchildiChat/matrix-react-sdk
that referenced
this pull request
Nov 4, 2022
* Fix default behavior of Room.getBlacklistUnverifiedDevices ([\matrix-org#2830](matrix-org/matrix-js-sdk#2830)). Contributed by @duxovni. * Catch server versions API call exception when starting the client ([\matrix-org#2828](matrix-org/matrix-js-sdk#2828)). Fixes element-hq/element-web#23634. * Fix authedRequest including `Authorization: Bearer undefined` for password resets ([\matrix-org#2822](matrix-org/matrix-js-sdk#2822)). Fixes element-hq/element-web#23655.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#23634
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes