Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint to remind you not to leave an focused/exclusive test in #2859

Closed

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Nov 7, 2022

Relevant rule: https://github.com/jest-community/eslint-plugin-jest/blob/ad04fcc97b5dcc676c5bd2152f84608c08e0c50a/docs/rules/no-focused-tests.md

Spawning from #2856 (comment)

Alternatives

There are other ways we could add this functionality but this seems most relevant to us. https://timdeschryver.dev/blog/dont-commit-focused-tests has a decent summary.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@MadLittleMods MadLittleMods added the T-Task Tasks for the team like planning label Nov 7, 2022
@t3chguy
Copy link
Member

t3chguy commented Nov 7, 2022

This should live in https://github.com/matrix-org/eslint-plugin-matrix-org

@MadLittleMods
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants