Always mark legacy threaded event as read #3020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
reviewed
Jan 4, 2023
src/models/thread.ts
Outdated
Comment on lines
517
to
521
|
|
||
| // We consider all threaded events read if they are part of a thread | ||
| // that has no activity since the first ever threaded event recorded in that room | ||
| // This prevents rooms to generated unwanted notifications for threads | ||
| // created before MSC3771 |
There was a problem hiding this comment.
I'm finding this comment very difficult to read, maybe the following is a bit clearer:
Suggested change
| // We consider all threaded events read if they are part of a thread | |
| // that has no activity since the first ever threaded event recorded in that room | |
| // This prevents rooms to generated unwanted notifications for threads | |
| // created before MSC3771 | |
| // We consider all events in a thread as read if the thread has not had | |
| // activity since the first ever threaded receipt recorded in that room. | |
| // This prevents rooms generating unwanted notifications for threads | |
| // created before MSC3771. |
clokep
reviewed
Jan 4, 2023
Comment on lines
+2728
to
+2731
|
|
||
| // Some threads were created before MSC3771 landed. Those threads | ||
| // do not have read receipts, and this will be problematic in encrypted | ||
| // rooms where clients rely on receipts to compute highlight notifications |
There was a problem hiding this comment.
Is this actually necessary for more than the "bold" case of thread activity?
3 tasks
3 tasks
|
Replaced by #3031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for matrix-org/matrix-react-sdk#9763
Will help element-hq/element-web#23907
Checklist
Here's what your changelog entry will look like:
✨ Features