Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for getVisibleRooms #3038

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Tests for getVisibleRooms #3038

merged 1 commit into from
Jan 10, 2023

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Jan 9, 2023 •
edited by github-actions bot
Loading

This is prep for an implementation of MSC3946

This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Tasks for the team like planning label Jan 9, 2023
@andybalaam andybalaam marked this pull request as ready for review January 9, 2023 12:27
@andybalaam andybalaam requested a review from a team as a code owner January 9, 2023 12:27
richvdh
richvdh approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and clear!

@andybalaam andybalaam merged commit e2ce379 into matrix-org:develop Jan 10, 2023
@andybalaam andybalaam deleted the andybalaam/tests-for-getVisibleRooms branch January 10, 2023 10:07
artcodespace
artcodespace approved these changes Jan 10, 2023
View reviewed changes
Copy link

@artcodespace artcodespace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a single (non-blocking) question

spec/unit/matrix-client.spec.ts Show resolved Hide resolved
@andybalaam andybalaam mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artcodespace artcodespace artcodespace approved these changes

@richvdh richvdh richvdh approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andybalaam @richvdh @artcodespace