Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: sliding sync: swap to lists-as-keys #3086

Merged
merged 6 commits into from
Jan 23, 2023
Merged

refactor: sliding sync: swap to lists-as-keys #3086

merged 6 commits into from
Jan 23, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Jan 23, 2023 •
edited by github-actions bot
Loading

Update the request/response API shape to match the latest MSC3575 version, which converts lists from being an array of list objects to being a map of list objects.

This was already approved in #3076 but it landed too early so had to be backed out.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kegsay
refactor: sliding sync: swap to lists-as-keys
d72ddfd 
Update the request/response API shape to match the latest
MSC3575 version, which converts `lists` from being an array
of list objects to being a map of list objects.
@kegsay
Linting
d3e0839
@kegsay
prettier
22177ab
@kegsay
add extra setListRanges test
a6d5bd6
@kegsay
Default to right type
871cd03
@kegsay kegsay requested a review from a team as a code owner January 23, 2023 13:01
@kegsay kegsay requested a review from dbkr January 23, 2023 13:01
@kegsay kegsay added the T-Task Tasks for the team like planning label Jan 23, 2023
@kegsay kegsay mentioned this pull request Jan 23, 2023
Merged
3 tasks
andybalaam
andybalaam approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approved, as mentioned.

@andybalaam andybalaam merged commit 6cf6a0c into develop Jan 23, 2023
@andybalaam andybalaam deleted the kegan/lists-as-keys branch January 23, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kegsay @andybalaam