Move the logic of roomPredecessor into the RoomState class #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
reviewed
Jan 30, 2023
src/models/room-state.ts
Outdated
| const predecessorEvent = this.getStateEvents(EventType.RoomPredecessor, ""); | ||
| if (predecessorEvent) { | ||
| const roomId = predecessorEvent.getContent()["predecessor_room_id"]; | ||
| if (roomId) { |
There was a problem hiding this comment.
Suggested change
| if (roomId) { | |
| if (typeof roomId === "string") { |
For safety, since we can't trust the contents of events to match the types we want
There was a problem hiding this comment.
Thank you, fixed in 558392c
| const roomId = predecessor["room_id"]; | ||
| if (roomId) { | ||
| const eventId = predecessor["event_id"] || null; | ||
| return { roomId, eventId }; |
There was a problem hiding this comment.
These two are also missing type checks
There was a problem hiding this comment.
Thank you, fixed in 558392c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#24323
This change is marked as an internal change (Task), so will not be included in the changelog.