Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polls push rules #3181

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Polls push rules #3181

merged 4 commits into from
Mar 1, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Feb 28, 2023 •
edited by github-actions bot
Loading

  • adds polls push rule ids from MSC3930
  • adds function to retrieve a user's rule and kind by id getPushRuleAndKindById - used here

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Tasks for the team like planning label Feb 28, 2023
@kerryarchibald kerryarchibald requested a review from a team as a code owner February 28, 2023 21:52
andybalaam
andybalaam approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kerryarchibald kerryarchibald added this pull request to the merge queue Mar 1, 2023
Merged via the queue into develop with commit 933a0c9 Mar 1, 2023
@kerryarchibald kerryarchibald deleted the psg-955/polls-push-sync branch March 1, 2023 20:55
This was referenced Mar 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @andybalaam