Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Total summary count #3351

Merged
merged 18 commits into from
May 14, 2023
Merged

Total summary count #3351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d304cc4
add audio concealment to stats report
toger5 May 8, 2023
874cd96
audio concealment to summary
toger5 May 9, 2023
cb577f4
make ts linter happy
toger5 May 10, 2023
8ce9783
format and rename
toger5 May 10, 2023
a6a1aad
fix and add tests
toger5 May 10, 2023
ee54c8d
make it prettier!
toger5 May 10, 2023
fb3bdc3
we can make it even prettier ?!
toger5 May 10, 2023
31c03d4
review
toger5 May 12, 2023
dbe4589
fix tests
toger5 May 12, 2023
8da4dde
pretty
toger5 May 12, 2023
01dbc71
one empty line to ...
toger5 May 12, 2023
a7d4c32
remove ratio in audio concealment (ratio is now done in the summary)
toger5 May 12, 2023
9c4bf19
remove comment
toger5 May 12, 2023
18360da
fix test
toger5 May 12, 2023
85eb97f
Merge branch 'develop' into audio-concealment
toger5 May 12, 2023
113056c
add peer connections to summary report
toger5 May 10, 2023
e707657
Merge branch 'develop' into totalSummaryCount
toger5 May 14, 2023
006ccdf
tests
toger5 May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions spec/unit/webrtc/stats/summaryStatsReporter.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 0.75,
maxJitter: 0,
maxPacketLoss: 0,
peerConnections: 4,
percentageConcealedAudio: 0.0375,
});
});
Expand Down Expand Up @@ -160,6 +161,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 1,
maxJitter: 0,
maxPacketLoss: 0,
peerConnections: 1,
percentageConcealedAudio: 0,
});
});
Expand Down Expand Up @@ -195,6 +197,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 0,
maxJitter: 0,
maxPacketLoss: 0,
peerConnections: 1,
percentageConcealedAudio: 0,
});
});
Expand Down Expand Up @@ -230,6 +233,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 1,
maxJitter: 0,
maxPacketLoss: 0,
peerConnections: 1,
percentageConcealedAudio: 0,
});
});
Expand Down Expand Up @@ -328,6 +332,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 1,
maxJitter: 20,
maxPacketLoss: 40,
peerConnections: 4,
percentageConcealedAudio: 0,
});
});
Expand Down Expand Up @@ -363,6 +368,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 1,
maxJitter: 0,
maxPacketLoss: 0,
peerConnections: 1,
percentageConcealedAudio: 0,
});
});
Expand Down Expand Up @@ -398,6 +404,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 1,
maxJitter: 0,
maxPacketLoss: 0,
peerConnections: 1,
percentageConcealedAudio: 0,
});
});
Expand Down Expand Up @@ -433,6 +440,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 1,
maxJitter: 0,
maxPacketLoss: 0,
peerConnections: 1,
percentageConcealedAudio: 0,
});
});
Expand Down
1 change: 1 addition & 0 deletions src/webrtc/stats/statsReport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,5 @@ export interface SummaryStatsReport {
maxJitter: number;
maxPacketLoss: number;
percentageConcealedAudio: number;
peerConnections: number;
}
1 change: 1 addition & 0 deletions src/webrtc/stats/summaryStatsReporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export class SummaryStatsReporter {
? (summaryCounter.concealedAudio / summaryCounter.totalAudio).toFixed(decimalPlaces)
: 0,
),
peerConnections: summaryTotalCount,
} as SummaryStatsReport;
this.emitter.emitSummaryStatsReport(report);
}
Expand Down