Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more context for why threaded vs unthreaded read receipts #3378

Merged
merged 3 commits into from
May 24, 2023
Merged

Add more context for why threaded vs unthreaded read receipts #3378

merged 3 commits into from
May 24, 2023

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented May 17, 2023 •
edited by github-actions bot
Loading

Add more context for why threaded vs unthreaded read receipts

See #3339 (comment)

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@MadLittleMods MadLittleMods added A-Documentation T-Task Tasks for the team like planning labels May 17, 2023
@MadLittleMods MadLittleMods mentioned this pull request May 17, 2023
Merged
andybalaam
andybalaam requested changes May 18, 2023
View reviewed changes
Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested different wording to make unthreaded receipts sound less weird (we do send them ourselves) and to explain a little about Sync Order.

src/receipt-accumulator.ts Show resolved Hide resolved
@MadLittleMods MadLittleMods marked this pull request as ready for review May 18, 2023 16:53
@MadLittleMods MadLittleMods requested a review from a team as a code owner May 18, 2023 16:53
@MadLittleMods MadLittleMods requested review from richvdh, alunturner and andybalaam and removed request for richvdh and alunturner May 18, 2023 16:53
@andybalaam
Copy link
Contributor

Great, thank you for making the effort @MadLittleMods

@andybalaam andybalaam added this pull request to the merge queue May 24, 2023
Merged via the queue into develop with commit ed71cde May 24, 2023
@andybalaam andybalaam deleted the madlittlemods/better-read-receipt-context branch May 24, 2023 11:13
@MadLittleMods
Copy link
Contributor Author

Thanks for the review and merge @andybalaam 🪺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

Assignees
No one assigned
Labels
A-Documentation T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MadLittleMods @andybalaam