Fix verification bug with pendingEventOrdering: "chronological"
#3382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There exists a bug (in the legacy
Crypto
implementation), in which in-room verifications-via-emoji will fail for applications which use the defaultpendingEventOrdering
setting.The basis of the problem is that the verifier sees a local echo of our own outgoing
m.key.verification.mac
. It tries to verify the MAC in that message, which of course fails.The solution is to treat such local echoes in the same way as remote echoes.
Here's what your changelog entry will look like:
🐛 Bug Fixes
pendingEventOrdering: "chronological"
(#3382).