Test inserting edit events into the thread timeline "on demand" #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While attempting to test a new change, I discovered that the test "should allow edits to be added to thread timeline" did not actually fail if its assertions failed. Further, those assertions were incorrect. So this change fixes the test to create the thread, wait for it to be initialised, and then add events to it. This simplifies the flow and ensures the test fails if something unexpected happens.
Modifies fetchEditsWhereNeeded to allow edits of threaded messages. The code before prevented any relations from fetching edits, but of course events in threads are relations. We definitely want thread messages to get their edits fetched, and I assume this is working in the real code, probably because the event being looked at is some kind of eventmapped thing that doesn't have proper relations visible on it. In tests, if we don't make this change, we can't see edits getting fetched.
This test demonstrates the current behaviour, which contains a bug - we don't actually add the right event to the timeline.
andybalaam
requested review from
germain-gg and
robintown
and removed request for
a team
|
I suggest we bypass the coverage check since this change adds a test, so can't be bad :-) |
robintown
approved these changes
May 25, 2023
robintown
reviewed
May 25, 2023
robintown
reviewed
May 25, 2023
| @@ -510,6 +510,45 @@ describe("Thread", () => { | |||
| // And the first message has been edited | |||
| expect(secondLastEvent.getContent().body).toEqual("edit"); | |||
| }); | |||
|
|
|||
| it("Adds edits fetched on demand to the thread timeline and applies them", async () => { | |||
There was a problem hiding this comment.
Suggested change
| it("Adds edits fetched on demand to the thread timeline and applies them", async () => { | |
| it("applies edits fetched on demand", async () => { |
I'd be more comfortable if this test's title were honest about what it's really testing at the moment ^^
There was a problem hiding this comment.
Please forgive me for not doing this.. I promise I'll merge #3398 very very soon.
It was going to topple my tower of PRs :-)
|
Force merging because the coverage check is not relevant a change that is pure tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest reviewing commit by commit.
The main point of this change is to get a test in place that will allow us to fix a bug we inserted in #3384 where we added the wrong event to the timeline. This change doesn't fix the bug, but does add a test we can use to validate the fix later.
In order to do this, I had to fix a small problem where fetchEditsWhenNeeded ignored threaded messages. I assume they are not ignored in production, but I am not at all sure. Maybe I've misunderstood what this line of code is for:
Part of element-hq/element-web#10954
This change is marked as an internal change (Task), so will not be included in the changelog.