Upgrade JS-DevTools/npm-publish to v2.2.0 #3456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
|
@mcous really appreciate your contribution here, any chance you could DCO sign off as per https://github.com/vector-im/element-web/blob/develop/CONTRIBUTING.md#sign-off |
- Upgrade JS-DevTools/npm-publish to v2.2.0 - Remove workaround for bug JS-DevTools/npm-publish#15 - Remove usage of `jq` in favor of npm-publish output Signed-off-by: Michael Cousins <michael@cousins.io>
mcous
force-pushed
the
chore-upgrade-npm-publish
branch
from
0cf9a48 to
647bc1e
Compare
t3chguy
approved these changes
Jun 14, 2023
|
Please feel free to ping me here or in JS-DevTools/npm-publish if you run into any issues with this action moving forward! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hi! I was checking in on closed issues in JS-DevTools/npm-publish and noticed a link-back in JS-DevTools/npm-publish#15 to #3350.
Since
npm-publish@v1uses deprecated GitHub Actions APIs that could stop working at any point, I wanted to help y'all get on v2. There seemed to be two breaking changes that affected your repository:.npmrcby replacingNODE_AUTH_TOKEN(added byactions/setup-node) withINPUT_TOKEN, v2 no longer makes this modificationnpm publish, v2 callsnpm publish --ignore-scriptsThis PR upgrades the npm-publish package to v2 and modifies the publish workflow accordingly.
Change log
jqin favor of npm-publish outputChecklist
This change is marked as an internal change (Task), so will not be included in the changelog.