Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pagination limit to account for threaded events #3638

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Bump pagination limit to account for threaded events #3638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46ed24e
Bump pagination limit to account for threaded events
t3chguy Jul 31, 2023
bb1a254
Merge branch 'develop' into t3chguy/bump-pagination
t3chguy Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/timeline-window.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,13 @@ const debuglog = DEBUG ? logger.log.bind(logger) : function (): void {};

/**
* the number of times we ask the server for more events before giving up
* this is currently higher than it needs to be to workaround lack of a filter
* for excluding thread responses from main timeline pagination which can cause
* giving up incorrectly - https://github.com/matrix-org/matrix-spec-proposals/pull/3874
*
* @internal
*/
const DEFAULT_PAGINATE_LOOP_LIMIT = 5;
const DEFAULT_PAGINATE_LOOP_LIMIT = 10;

interface IOpts {
/**
Expand Down