Comments attempting to explain the addEvent method #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to try and help debug element-hq/element-web#26254
andybalaam
force-pushed
the
andybalaam/comments-in-addevent
branch
from
34a1865 to
5499834
Compare
andybalaam
changed the base branch from
develop
to
andybalaam/warn-when-dropping-messages-in-addevent
Base automatically changed from
andybalaam/warn-when-dropping-messages-in-addevent
to
develop
October 6, 2023 15:16
richvdh
approved these changes
Oct 9, 2023
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of my work on element-hq/element-web#26254
This change is marked as an internal change (Task), so will not be included in the changelog.