ElementR: report invalid keys rather than failing to restore from backup #4006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matrix-org/matrix-rust-sdk-crypto-wasm#85 is merged, so this can be reviewed now. |
richvdh
reviewed
Jan 21, 2024
There was a problem hiding this comment.
Presumably this won't actually work until matrix-sdk-crypto-wasm is updated (element-hq/element-web#26900)?
Also, would be nice to see a test.
uhoreg
changed the title
Wrote a test and found another place where importing could fail. |
richvdh
reviewed
Jan 25, 2024
richvdh
reviewed
Jan 25, 2024
richvdh
reviewed
Jan 26, 2024
src/rust-crypto/backup.ts
Outdated
Comment on lines
219
to
220
| // since we didn't include the invalid keys when calling | ||
| // importBackedUpRoomKeys, we need to add them to the total |
There was a problem hiding this comment.
this comment no longer makes sense.
richvdh
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix-org/matrix-rust-sdk-crypto-wasm#85 adds a parameter to the importBackedUpRoomKeys callback that adds a parameter giving the number of failures. This PR passes that information along.
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes