Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency fake-indexeddb to v6 #4224

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 29, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
fake-indexeddb ^5.0.2 -> ^6.0.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

dumbmatter/fakeIndexedDB (fake-indexeddb)

v6.0.0

Compare Source

I made this a new major version because it includes a few changes that could in theory break something in some weird situations. But I think the vast majority of users (possibly all users?) won't have any issue upgrading.

  • #​48 - Switched to using DOMException errors rather than normal errors, since that's what the IndexedDB spec says to use, and Node.js now has a built-in DOMException in all supported versions.

  • #​93 - @​bryan-codaio made the latest tweak to event scheduling, this time improving how setImmediate is used in some situations where people are mocking timers.

  • #​99 - @​sjnho fixed handling of Date objects to account for some edge cases, including jsdom overriding the native Date constructor.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added Dependencies Pull requests that update a dependency file T-Task Tasks for the team like planning labels May 29, 2024
dbkr added a commit that referenced this pull request May 29, 2024
dumbmatter/fakeIndexedDB#93 causes a bunch
of tests to start failing because the fake timers need running in
order for fake indexeddb to work. It also seems to cause failures
to bleed between tests somehow if fake timers are enabled/disabled.
This keeps all the fake timer tests in one suite and all the others
in another, which appears to work.

This should allow #4224
to be merged.
github-merge-queue bot pushed a commit that referenced this pull request May 30, 2024
dumbmatter/fakeIndexedDB#93 causes a bunch
of tests to start failing because the fake timers need running in
order for fake indexeddb to work. It also seems to cause failures
to bleed between tests somehow if fake timers are enabled/disabled.
This keeps all the fake timer tests in one suite and all the others
in another, which appears to work.

This should allow #4224
to be merged.
@renovate renovate bot force-pushed the renovate/fake-indexeddb-6.x branch from ea44ea1 to 000aea0 Compare May 30, 2024 15:42
@dbkr
Copy link
Member

dbkr commented May 30, 2024

Eugh, this breaks a whole bunch of our tests because anything that uses fake timers now needs to advance them for indexeddb to work. I fixed the queueToDevice ones in #4225 but now there a load more. Really feels like fake-indexeddb should have an option to pass a timer function in to bypass the fake timers or something.

@renovate renovate bot force-pushed the renovate/fake-indexeddb-6.x branch from 9289989 to 8a513f1 Compare June 19, 2024 08:50
@renovate renovate bot force-pushed the renovate/fake-indexeddb-6.x branch from 8a513f1 to 042303f Compare June 25, 2024 13:39
@renovate renovate bot force-pushed the renovate/fake-indexeddb-6.x branch from 042303f to f74933d Compare June 25, 2024 15:03
@renovate renovate bot force-pushed the renovate/fake-indexeddb-6.x branch from f74933d to ea79fd0 Compare June 25, 2024 15:25
@renovate renovate bot force-pushed the renovate/fake-indexeddb-6.x branch 2 times, most recently from 80ee6bb to e7cbbf8 Compare July 8, 2024 15:47
@renovate renovate bot force-pushed the renovate/fake-indexeddb-6.x branch from e7cbbf8 to 1e39e62 Compare July 9, 2024 14:10
@renovate renovate bot force-pushed the renovate/fake-indexeddb-6.x branch from 1e39e62 to 2691796 Compare July 24, 2024 16:57
@renovate renovate bot force-pushed the renovate/fake-indexeddb-6.x branch from 2691796 to c49e422 Compare August 21, 2024 14:11
@renovate renovate bot force-pushed the renovate/fake-indexeddb-6.x branch from c49e422 to ca94654 Compare August 21, 2024 16:43
@renovate renovate bot force-pushed the renovate/fake-indexeddb-6.x branch from ca94654 to c10a7ed Compare August 22, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant