-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crypto methods for export and import of secrets bundle #4227
Changes from all commits
30c8ba6
30e586a
fc59cf0
4a00109
235d1d4
af07b84
7bfe091
ff83fe8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/* | ||
Copyright 2024 The Matrix.org Foundation C.I.C. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
import type * as RustSdkCryptoJs from "@matrix-org/matrix-sdk-crypto-wasm"; | ||
|
||
declare module "@matrix-org/matrix-sdk-crypto-wasm" { | ||
interface OlmMachine { | ||
importSecretsBundle(bundle: RustSdkCryptoJs.SecretsBundle): Promise<void>; | ||
exportSecretsBundle(): Promise<RustSdkCryptoJs.SecretsBundle>; | ||
} | ||
|
||
interface SecretsBundle { | ||
// eslint-disable-next-line @typescript-eslint/naming-convention | ||
to_json(): Promise<{ | ||
cross_signing: { | ||
master_key: string; | ||
self_signing_key: string; | ||
user_signing_key: string; | ||
}; | ||
backup?: { | ||
algorithm: string; | ||
key: string; | ||
backup_version: string; | ||
}; | ||
}>; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,6 +38,7 @@ import { | |
CrossSigningKey, | ||
CrossSigningKeyInfo, | ||
CrossSigningStatus, | ||
CryptoApi, | ||
CryptoCallbacks, | ||
Curve25519AuthData, | ||
DecryptionFailureCode, | ||
|
@@ -1165,6 +1166,26 @@ export class RustCrypto extends TypedEventEmitter<RustCryptoEvents, RustCryptoEv | |
this.checkKeyBackupAndEnable(); | ||
} | ||
|
||
/** | ||
* Implementation of {@link CryptoApi#importSecretsBundle}. | ||
*/ | ||
public async importSecretsBundle( | ||
secrets: Parameters<NonNullable<CryptoApi["importSecretsBundle"]>>[0], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I still think there's way too much type magic going on here. As a caller of this function, how am I meant to build one of these things? ... I'm not going to block the PR further on it, though. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
you shouldn't construct manually, only ever exported by the matching export function |
||
): Promise<void> { | ||
const secretsBundle = RustSdkCryptoJs.SecretsBundle.from_json(secrets); | ||
await this.getOlmMachineOrThrow().importSecretsBundle(secretsBundle); // this method frees the SecretsBundle | ||
} | ||
|
||
/** | ||
* Implementation of {@link CryptoApi#exportSecretsBundle}. | ||
*/ | ||
public async exportsSecretsBundle(): ReturnType<NonNullable<CryptoApi["exportSecretsBundle"]>> { | ||
const secretsBundle = await this.getOlmMachineOrThrow().exportSecretsBundle(); | ||
const secrets = secretsBundle.to_json(); | ||
secretsBundle.free(); | ||
return secrets; | ||
} | ||
|
||
/** | ||
* Signs the given object with the current device and current identity (if available). | ||
* As defined in {@link https://spec.matrix.org/v1.8/appendices/#signing-json | Signing JSON}. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this? isn't it already in the index.d.ts of
matrix-sdk-crypto-wasm
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but with return types of
any
- see matrix-org/matrix-rust-sdk-crypto-wasm#110There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed on the wasm side; matrix-org/matrix-rust-sdk-crypto-wasm#123 does so but it will need a release cycle :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that PR doesn't help with the return type of
SecretsBundle.to_json
, to be fair. On the other hand: do you actually need to introspect the result ofSecretsBundle.to_json
outside of tests (where I would be inclined to do some@ts-ignore
ing rather than have a separate definition to keep in step)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should still be a useful type otherwise you'll get junk into the import method. If it isn't meant to be introspectable then it should be a branded type so a round-trip export->import works without needing to rely on
any