Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use legacy call membership if anyone else is #4260

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Use legacy call membership if anyone else is #4260

merged 9 commits into from
Jun 21, 2024

Conversation

AndrewFerr
Copy link
Member

Signed-off-by: Andrew Ferrazzutti andrewf@element.io

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@AndrewFerr AndrewFerr requested a review from toger5 June 20, 2024 03:00
@toger5
Copy link
Contributor

toger5 commented Jun 20, 2024

Can you also add this change:
image

@toger5
Copy link
Contributor

toger5 commented Jun 20, 2024

Thanks for porting this into its own PR and making it better!

AndrewFerr
AndrewFerr commented Jun 20, 2024
View reviewed changes
src/matrixrtc/MatrixRTCSession.ts Show resolved Hide resolved
src/matrixrtc/MatrixRTCSession.ts Outdated Show resolved Hide resolved
@AndrewFerr AndrewFerr marked this pull request as ready for review June 20, 2024 13:42
@AndrewFerr AndrewFerr requested a review from a team as a code owner June 20, 2024 13:42
toger5
toger5 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks.

src/matrixrtc/MatrixRTCSession.ts Show resolved Hide resolved
@AndrewFerr AndrewFerr added this pull request to the merge queue Jun 21, 2024
Merged via the queue into matrix-org:develop with commit 6a15e8f Jun 21, 2024
24 checks passed
@AndrewFerr AndrewFerr deleted the af/legacy-call-fallback branch June 21, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toger5 toger5 toger5 approved these changes

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewFerr @toger5