Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rust Crypto SDK to 6.1.0 #4261

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 20, 2024

Fixes element-hq/element-web#27590

Notes: fix a bug (element-hq/element-web#27590) which could cause messages sent before migration to Rust Crypto are incorrectly shown as Expected UTDs.

Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to upgrade the version in the package.json too? I guess we want at minimum the 6.1.0 of the sdk crypto

@richvdh
Copy link
Member Author

richvdh commented Jun 20, 2024

We don't want to upgrade the version in the package.json too? I guess we want at minimum the 6.1.0 of the sdk crypto

I don't think that's necessary: it's not that our code is incompatible with 6.0.0, it's just that we prefer 6.1.0 because it has bug fixes. Same as any other update of our dependencies like those that come from renovate (eg #4258): we don't normally bump the requirements in package.json.

@florianduros florianduros self-requested a review June 20, 2024 08:25
@richvdh richvdh enabled auto-merge June 20, 2024 08:26
@richvdh richvdh added this pull request to the merge queue Jun 20, 2024
Merged via the queue into develop with commit 238eea0 Jun 20, 2024
32 checks passed
@richvdh richvdh deleted the rav/element-r/rust_sdk_6_1_0 branch June 20, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UTD messages sent before migration to Rust Crypto are incorrectly shown as Expected UTDs
2 participants