Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MatrixRTC sender key wrapping #4441

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

hughns
Copy link
Member

@hughns hughns commented Oct 2, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense if currentEncryptionKeyIndex is sth that is available to us anyways.

@hughns hughns added the T-Defect label Oct 2, 2024
@hughns hughns marked this pull request as ready for review October 2, 2024 09:35
@hughns hughns requested a review from a team as a code owner October 2, 2024 09:35
@hughns hughns marked this pull request as draft October 2, 2024 12:59
@hughns
Copy link
Member Author

hughns commented Oct 2, 2024

I found since that we actually need to make the maximum key index configurable depending on which MatrixRTC backend is being used.

MSC4143 will actually mandate 256 indices, so this can stay for now.

@hughns hughns marked this pull request as ready for review October 2, 2024 14:57
@hughns hughns requested a review from toger5 October 2, 2024 14:57
@hughns hughns added this pull request to the merge queue Oct 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2024
@hughns hughns added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@hughns hughns added this pull request to the merge queue Oct 7, 2024
Merged via the queue into develop with commit 3386c66 Oct 7, 2024
38 of 39 checks passed
@hughns hughns deleted the hughns/matrixrtc-key-wrapping branch October 7, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants