Allow configuration of MatrixRTC timers when calling joinRoomSession() #4510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughns
added
the
T-Feature
hughns
added
T-Enhancement
and removed
T-Feature
4 tasks
toger5
approved these changes
Nov 11, 2024
| * The timeout (in milliseconds) after which the server will consider the membership to have expired if it | ||
| * has not received a keep-alive from the client. | ||
| */ | ||
| membershipServerSideExpiryTimeout?: number; |
There was a problem hiding this comment.
Do you think it is beneficial to use sth close to the delay event terminology since this is what one would look out for to configure the even delay timeout?
| /** | ||
| * The period (in milliseconds) that the client will send membership keep-alives to the server. | ||
| */ | ||
| membershipKeepAlivePeriod?: number; |
There was a problem hiding this comment.
here something with refresh
|
My thinking on the naming is that we choose things that make sense with respect to MatrixRTC concepts. But, as you say it can be argued out and refactored later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all of the new config options are being tested, but the code coverage is still reached.
The use of
Math.random()that is flagged by SonarCloud is acceptable.Checklist
public/exportedsymbols have accurate TSDoc documentation.