Remove legacy crypto #4653
Merged
Remove legacy crypto #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crypto/call Remove deprecated calls in `webrtc/call.ts`
This was referenced Jan 23, 2025
This was referenced Jan 27, 2025
* chore(legacy call): Remove `DeviceInfo` usage * refactor(legacy call): throw `GroupCallUnknownDeviceError` at the end of `initOpponentCrypto`
* feat(legacy crypto)!: remove deprecated methods of `MatrixClient`
* test(legacy crypto): update existing tests to not use legacy crypto
- `Embedded.spec.ts`: casting since `encryptAndSendToDevices` is removed from `MatrixClient`.
- `room.spec.ts`: remove deprecated usage of `MatrixClient.crypto`
- `matrix-client.spec.ts` & `matrix-client-methods.spec.ts`: remove calls of deprecated methods of `MatrixClient`
* test(legacy crypto): remove test files using `MatrixClient` deprecated methods
* test(legacy crypto): update existing integ tests to run successfully
* feat(legacy crypto!): remove `ICreateClientOpts.deviceToImport`.
`ICreateClientOpts.deviceToImport` was used in the legacy cryto. The rust crypto doesn't support to import devices in this way.
* feat(legacy crypto!): remove `{get,set}GlobalErrorOnUnknownDevices`
`globalErrorOnUnknownDevices` is not used in the rust-crypto. The API is marked as unstable, we can remove it.
This was referenced Jan 28, 2025
Merged
This was referenced Jan 29, 2025
This was referenced Jan 29, 2025
Where was the list of component parts which are to be PR'd individually reviewed? What's to say all the PRs have been made now and there doesn't need to be further PRs made onto this feature branch? If we don't review this then what's to stop the component sum of all the PRs not being acceptable? |
…-legacy-crypto # Conflicts: # spec/TestClient.ts # spec/integ/crypto/cross-signing.spec.ts # spec/integ/crypto/crypto.spec.ts # spec/integ/crypto/megolm-backup.spec.ts # spec/integ/crypto/olm-encryption-spec.ts # spec/integ/crypto/to-device-messages.spec.ts # spec/integ/crypto/verification.spec.ts # spec/integ/matrix-client-methods.spec.ts # spec/integ/matrix-client-syncing.spec.ts # spec/unit/crypto.spec.ts # spec/unit/crypto/DeviceList.spec.ts # spec/unit/crypto/algorithms/megolm.spec.ts # spec/unit/crypto/algorithms/olm.spec.ts # spec/unit/crypto/backup.spec.ts # spec/unit/crypto/cross-signing.spec.ts # spec/unit/crypto/crypto-utils.ts # spec/unit/crypto/outgoing-room-key-requests.spec.ts # spec/unit/crypto/secrets.spec.ts # spec/unit/crypto/verification/InRoomChannel.spec.ts # spec/unit/crypto/verification/sas.spec.ts # spec/unit/crypto/verification/secret_request.spec.ts # spec/unit/crypto/verification/util.ts # spec/unit/crypto/verification/verification_request.spec.ts # spec/unit/embedded.spec.ts # spec/unit/matrix-client.spec.ts # spec/unit/models/event.spec.ts # spec/unit/room.spec.ts # src/client.ts # src/common-crypto/CryptoBackend.ts # src/crypto/CrossSigning.ts # src/crypto/DeviceList.ts # src/crypto/EncryptionSetup.ts # src/crypto/OlmDevice.ts # src/crypto/OutgoingRoomKeyRequestManager.ts # src/crypto/RoomList.ts # src/crypto/SecretSharing.ts # src/crypto/SecretStorage.ts # src/crypto/algorithms/base.ts # src/crypto/algorithms/megolm.ts # src/crypto/algorithms/olm.ts # src/crypto/api.ts # src/crypto/backup.ts # src/crypto/dehydration.ts # src/crypto/device-converter.ts # src/crypto/deviceinfo.ts # src/crypto/index.ts # src/crypto/keybackup.ts # src/crypto/olmlib.ts # src/crypto/store/base.ts # src/crypto/store/indexeddb-crypto-store-backend.ts # src/crypto/store/indexeddb-crypto-store.ts # src/crypto/store/localStorage-crypto-store.ts # src/crypto/store/memory-crypto-store.ts # src/crypto/verification/Base.ts # src/crypto/verification/IllegalMethod.ts # src/crypto/verification/QRCode.ts # src/crypto/verification/SAS.ts # src/crypto/verification/request/Channel.ts # src/crypto/verification/request/InRoomChannel.ts # src/crypto/verification/request/ToDeviceChannel.ts # src/crypto/verification/request/VerificationRequest.ts # src/embedded.ts # src/models/event.ts # src/sync.ts
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/remove-legacy-crypto
branch
from
d72a13b to
664e3fd
Compare
* chore(crypto): remove unused types * doc(crypto): add missing link
…-legacy-crypto # Conflicts: # src/models/event.ts
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/remove-legacy-crypto
branch
from
073e85c to
2e83fea
Compare
t3chguy
approved these changes
Feb 6, 2025
toger5
approved these changes
Feb 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
hughns
approved these changes
Feb 7, 2025
florianduros
deleted the
florianduros/rip-out-legacy-crypto/remove-legacy-crypto
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes element-hq/element-web#26922
EW e2e tests
Remove the legacy crypto. All included PRs have been reviewed.
webrtc/call.ts#4562DeviceInfoinwebrtc/call.ts#4654MatrixClient.initLegacyCrypto#4620syncapi #4622MatrixClient#4659event.ts#4666embedded.ts#4668CryptoBackend#4671matrix.ts#4667CryptoApi#4692