Add getMediaLimits to client #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
force-pushed
the
hs/upload-limits
branch
from
6fe95d1
to
9596087
Compare
turt2live
requested changes
Jun 20, 2018
src/client.js
Outdated
| @@ -727,6 +727,20 @@ MatrixClient.prototype.getGroups = function() { | |||
| return this.store.getGroups(); | |||
| }; | |||
|
|
|||
| /** | |||
| * Get the room for the given room ID. | |||
src/client.js
Outdated
| * @param {module:client.callback} callback Optional. | ||
| * @return {module:client.Promise} Resolves with an object containing the limits. | ||
| */ | ||
| MatrixClient.prototype.getMediaLimits = function(callback) { |
There was a problem hiding this comment.
This should probably just be getMediaRepoConfiguration or something, given the opportunity for future expansion.
There was a problem hiding this comment.
+++1 for magic this super generic
|
Aaaaaanyone? :( |
turt2live
approved these changes
Sep 26, 2018
turt2live
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of matrix-org/matrix-spec-proposals#1189 and matrix-org/synapse#3184