Redaction and change events for relations #911
Conversation
There was a problem hiding this comment.
For future PRs, please separate things like 00e4236 due to their size. It's fine for this PR because it's already done though.
I mostly have questions and github doesn't have an option for "this is probably fine but there's a path for more code depending on the answer to some questions".
As an aside: how does this behave if the relation comes in before the event? What if the event is cut off by limited: true on a sync but the relation is not? (not questions to fix for this PR)
Right, sorry... I try to separate when it makes sense to me. In this case, I was worried it would add lag to the review process for the feature.
Possibly badly, will need to test. 😅 We should be storing any relations as they come in, but haven't tried it yet. In the long run, we'll switch to server-side aggregation instead, which should handle those cases better. |
This enables compiler and linting features to allow class properties like we do in the React SDK.
This watches for redactions of relations and updates the relations collection to match, including various aggregations. In addition, a redaction event is emitted on the redaction collection to notify consumers of the change. Part of element-hq/element-web#9574 Part of element-hq/element-web#9485
…lections If you ask for relations but none currently exist, we return `null` to avoid the overhead of many empty relations objects in memory. However, we still want some way to alert consumers when one _is_ later made, so this event level event provides that. Part of element-hq/element-web#9572 Part of element-hq/element-web#9485
This adds a `Relations.add` event that consumers can listen for to be notified each time an additional relation event is added to a relations collection. Part of element-hq/element-web#9485 Part of element-hq/element-web#9572
This special cases pending relation events to go directly to the timeline sets and ignores the `pendingEventOrdering` option. This feels a bit strange in the code, so we should revisit this choice when we stabilized relation support.
jryans
force-pushed
the
jryans/aggregations
branch
from
3e02fea
to
f411d50
Compare
To avoid an O(n^2) situation with every relations container trying to process every redaction that may occur in a room, this switches to an event-level notification, so that the specific relations container who cares can listen to just the events it wants to know about.
Reviewer: Each commit in this PR is self-contained and has some additional context in the commit message, so you may want to review commit by commit.
This adds reactions and change event support needed for relations events in the JS SDK, which will be used for reactions and message editing features.
Fixes element-hq/element-web#9485
Part of element-hq/element-web#9572
Part of element-hq/element-web#9574
Used in matrix-org/matrix-react-sdk#2954